Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fixes #4532

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Test fixes #4532

merged 2 commits into from
Nov 15, 2023

Conversation

jgw96
Copy link
Contributor

@jgw96 jgw96 commented Nov 15, 2023

fixes #4531

PR Type

Build or CI related changes

Describe the current behavior?

Tests were failing because of the issue described in the linked bug.

Describe the new behavior?

Tests have been updated to:

  • account for the visually-hidden text
  • properly wait on the tests to pass before testing to see if the package button is disabled or not

PR Checklist

  • [x ] Test: run npm run test and ensure that all tests pass
  • [ xTarget main branch (or an appropriate release branch if appropriate for a bug fix)
  • [x ] Ensure that your contribution follows standard accessibility guidelines. Use tools like https://webhint.io/ to validate your changes.

Additional Information

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Thanks jgw96 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

beth-panx
beth-panx approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@beth-panx beth-panx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked like a charm! 🚀

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://polite-glacier-097fe8710-4532.centralus.2.azurestaticapps.net

@beth-panx beth-panx merged commit 2f76759 into staging Nov 15, 2023
7 of 8 checks passed
@beth-panx beth-panx deleted the ts-fixes branch November 15, 2023 23:45
@jgw96 jgw96 mentioned this pull request Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beth-panx beth-panx beth-panx approved these changes

@Jaylyn-Barbee Jaylyn-Barbee Awaiting requested review from Jaylyn-Barbee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgw96 @beth-panx